Conversation
NB there's also a fix to extensibleserialinstrument in pysangaboard... I've copied it in for now.
This ensures an action using the stage is cancelled properly, rather than the stage swallowing the cancellation.
rwb27
force-pushed
the
proscan
branch
2 times, most recently
from
266cbdb to
c27397a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've minimally modified this library to provide a Thing for Prior's ProScan III controller. Obviously it doesn't make a lot of sense for that to live in a package called
labthings-sangaboardbut this is where I've put it for now. Probably it should be split out into a separate repo, or we could rename this one tolabthings-serial-stages. Either way,ExtensibleSerialInstrumentwill be used by both - of course, nothing stopslabthings-proscandepending onlabthings-sangaboardand that is almost certainly the best way to publish it.I've made a prerelease to get a package with proscan support on PyPI, but I am not strongly suggesting that this should be included in
v0.0.2of this package.